Cinch Issue Tracker Rss Feed

Commented Issue: Compile Cinch.WPF.dll for Any CPU and publish to nuget [7128]

Disore — Fri, 21 Dec 2012 06:49:40 GMT

Compile Cinch.WPF.dll for Any CPU and publish to nuget
Comments: ** Comment from web user: Disore **

It seems that Debug configuration uses 'Any CPU', but Release configuration is still x86 for Cinch and Cinch.WPF.

Closed Issue: Compile Cinch.WPF.dll for Any CPU and publish to nuget [7128]

sachabarber — Thu, 20 Dec 2012 13:31:45 GMT

Compile Cinch.WPF.dll for Any CPU and publish to nuget
Comments:

DONE

Commented Issue: Compile Cinch.WPF.dll for Any CPU and publish to nuget [7128]

sachabarber — Thu, 20 Dec 2012 13:31:32 GMT

Compile Cinch.WPF.dll for Any CPU and publish to nuget
Comments: ** Comment from web user: sachabarber **

I have fixed the AnyCPU, but since the Cinch NuGet package was not created by me, I can't do anything about that. At least source code is AnyCPU now

Commented Issue: Compile Cinch.WPF.dll for Any CPU and publish to nuget [7128]

sachabarber — Sat, 29 Sep 2012 15:22:41 GMT

Compile Cinch.WPF.dll for Any CPU and publish to nuget
Comments: ** Comment from web user: sachabarber **

Unfortunately, a Cinch user was the one who created Nuget package, so you may need to contact them. if they could take theirs down I could prepare actual release

Created Issue: Compile Cinch.WPF.dll for Any CPU and publish to nuget [7128]

theperm — Thu, 13 Sep 2012 17:24:33 GMT

Compile Cinch.WPF.dll for Any CPU and publish to nuget

Closed Issue: Source files missing in cinch-66567 [6738]

sachabarber — Wed, 15 Feb 2012 12:55:54 GMT

Unable to compile. Missing source files for the following:

Obj/Interactive/Triggers
Obj/Interactive/Actions
Comments:

see what I said above

Commented Issue: Source files missing in cinch-66567 [6738]

sachabarber — Wed, 15 Feb 2012 12:55:40 GMT

Unable to compile. Missing source files for the following:

Obj/Interactive/Triggers
Obj/Interactive/Actions
Comments: ** Comment from web user: sachabarber **

Read the README.txt in CInchV2 solution and the Release Notes.docx document. All is explained in there.

Created Issue: Source files missing in cinch-66567 [6738]

eojnallistnas — Fri, 03 Feb 2012 18:16:06 GMT

Unable to compile. Missing source files for the following:

Obj/Interactive/Triggers
Obj/Interactive/Actions

Commented Issue: Incorrect documentation for SimpleRule [4535]

michaelmairegger — Tue, 29 Nov 2011 15:03:17 GMT

The ValidateRule method in SimpleRule states that the return value is "True if the rule has not been broken, or false if it has."

But in the ValidatingViewModelBase, the return value is mapped to a boolean named isRuleBroken, like so:

bool isRuleBroken = r.ValidateRule(this);

So either the documentation is wrong or the ValidatingViewModelBase has a bug. This caused me some confusion earlier today!
Comments: ** Comment from web user: michaelmairegger **

Code is fine, but the documentation isn't.
Should be "True if the rule has been broken, or false if it hasn't."
Because the variable that uses that method is called:
bool isRuleBroken = r.ValidateRule(this);
The user should always be aware that the returning true means that the rule is broken.

Regards,
Michael

Closed Issue: XamlParseException when runing Cinch Code Generator (30648) [2580]

sachabarber — Sun, 27 Nov 2011 18:15:59 GMT

When trying to execute CinchCodeGen.Exe either "Actual EXE" or by compiling it the next error is thrown:

Could not load file or assembly 'AqiStar.TextBox, Version=1.0.4758.0, Culture=neutral, PublicKeyToken=a73079b1a9f5484a' or one of its dependencies. An attempt was made to load a program with an incorrect format. Error at object 'System.Windows.ComponentResourceKey' in markup file 'CinchCodeGen;component/Resources/LanguageDefinitions/CSharpVSNET.xaml' Line 7 Position 26.
Comments:

Done

Closed Issue: Allow Mediator.Register to accept Action / Lambda for easier registering [2814]

sachabarber — Sun, 27 Nov 2011 18:15:22 GMT

Call me lazy, but sometimes I like to pass in a lambda expression to the Register function if I just need to do something simple in response to a Mediator message. The EventAggregator in PRISM allows this as well as passing a reference to a void method that takes one parameter.

I've added an overload to the Mediator class to allow for my lazy habits and I thought you, or someone else, would be interested in adding it to this project. Here's the code and some tests. I'll upload a patch when I have some time tonight.

/// <summary>
/// JBG - Convenience method for specifying lambda's as callbacks.
/// </summary>
/// <typeparam name="T">The type of parameter used by the callback</typeparam>
/// <param name="message">Identifies a series of callbacks</param>
/// <param name="callback">The action to perform when notified.</param>
public void Register<ParmType>(string message, Action<ParmType> callback)
{
if (callback.Target == null)
throw new InvalidOperationException("Delegate cannot be static");

// JBG - The Action<T> guarantees we have 1 and only 1 parameter.
Type parameterType = typeof(ParmType);

invocationList.AddAction(message, callback.Target,
callback.Method, parameterType);
}

/// <summary>
///A test for Register with Lambda expression.
///</summary>
[TestMethod()]
public void Should_Allow_Actions_To_Register_For_Events()
{
Mediator target = new Mediator();
string message = "testevent";

string result = string.Empty;

Action<string> callback =
(x) => result = x;

target.Register(message, callback);

Assert.AreNotEqual<string>("success", result);

target.NotifyColleagues<string>("testevent", "success");

Assert.AreEqual<string>(result, "success");
}

/// <summary>
///A test for Register with void method that takes one parameter.
///</summary>
[TestMethod()]
public void Should_Allow_Void_Methods_With_One_Parameter_To_Register_For_Events()
{
Mediator target = new Mediator();
string message = "testevent";

target.Register<string>(message, TestMethodWithString);

Assert.AreNotEqual<string>("success", _testResult);

target.NotifyColleagues<string>("testevent", "success");

Assert.AreEqual<string>(_testResult, "success");
}

private string _testResult = string.Empty;
private void TestMethodWithString(string blah)
{
_testResult = blah;
}

Hope someone else finds it useful.

Jacob
Comments:

Not an issue

Closed Issue: Pass EventArgs for SingleEventCommand as CommandParameter [2957]

sachabarber — Sun, 27 Nov 2011 18:15:10 GMT

Passing the EventArgs for the SingleEventCommand would be more helpful than passing null. Example: Passing KeyEventArgs for KeyDown would let you only execute some logic if a certain key was pressed.

To make this change, simply pass the EventArgs through as a parameter in the OnEventRaised method of the EventHooker class.

/// Runs the ICommand when the requested RoutedEvent fires
/// </summary>
private void OnEventRaised(object sender, EventArgs e)
{
ICommand command = (ICommand)(sender as DependencyObject).
GetValue(SingleEventCommand.TheCommandToRunProperty);

if (command != null)
{
command.Execute(e); // <--- change this from null to e to pass EventArgs
}
}
Comments:

Done

Closed Issue: SingleEventCommand can't work for DataContextChanged event. [3404]

sachabarber — Sun, 27 Nov 2011 18:14:58 GMT

I have tried many mvvm framework's event to command codes , all can't work for the the DataContextChanged event .
SingleEventCommand can't work for the DataContextChanged event too.

e.g: below code can't work.
////////////////////////////////////////////////////////////////////////////////////////////////////////
<TreeView>
<TreeViewItem Header="A"
cmd:SingleEventCommand.RoutedEventName="DataContextChanged"
cmd:SingleEventCommand.TheCommandToRun="{Binding Path=NewCommand}">
</TreeViewItem>
<TreeViewItem Header="B">
</TreeViewItem>
</TreeView>
////////////////////////////////////////////////////////////////////////////////////////////////////////
Comments:

Not an issue

Closed Issue: EventCommander or SingleEventCommand can't work for DependencyPropertyChanged Event. [3412]

sachabarber — Sun, 27 Nov 2011 18:14:40 GMT

private Delegate GetEventMethod(EventInfo ei)
{
if (ei == null)
throw new ArgumentNullException("ei");
if (ei.EventHandlerType == null)
throw new ArgumentException("EventHandlerType is null");
if (_method == null)
{
_method = Delegate.CreateDelegate(
ei.EventHandlerType, this,
GetType().GetMethod("OnEventRaised",
BindingFlags.NonPublic | BindingFlags.Instance));
}

for DependencyProperty, OnEventRaised should be changed to OnDependencyPropertyChangedEventRaised.
Comments:

Not an issue

Closed Issue: Mediator in ViewModelBase better be static. [3507]

sachabarber — Sun, 27 Nov 2011 18:14:26 GMT

in ViewModelBase.

public Mediator Mediator
{
get { return mediator; }
}

better be
public static Mediator Mediator
{
get { return mediator; }
}

then other class than can use it.
Comments:

Done

Closed Issue: NPE in WPFUIVisualizerService [4057]

sachabarber — Sun, 27 Nov 2011 18:14:12 GMT

Hi!

I am creating some WPF popups using Cinch. However, I am doing this for a unmanaged application.

As a result of this, Application.Current is null. This results in a NullPointerException in WPFUIVisualizerService.cs, line 140, if I call ShowDialog(). As a quick fix, I changed the two lines locally to:

if (setOwner && Application.Current != null)
win.Owner = Application.Current.MainWindow;

Daniel Rose
Comments:

Done

Closed Issue: Serialization of Cinch model objects [4122]

sachabarber — Sun, 27 Nov 2011 18:13:56 GMT

Hi!

I tried to add clipboard-support to my application, storing my model items, which derive from ValidatingObject. However, this didn't work. After a bit of checking, I found out that the problem was that the objects weren't serialized properly.

The problem is that the Cinch model objects are not serializable. While ValidatingObject itself is marked Serializable, this doesn't work:
1) The private List<Rule> rules cannot be serialized, because Rule, as well as SimpleRule/RegexRule, are not Serializable. Simply adding the attribute to the latter classes did the trick.
2) The INPC event is serialized; however this means that all current subscribers (such as the ViewModels) are also serialized. I marked the event with [field: NonSerialized] to prevent this. This means that any subscribers have to be restored, if necessary, upon deserialization.

Since I am not using the EditableValidatingObject or DataWrapper classes, I didn't check more deeply what would have to be done to make them Serializable. At least in the latter case, the parent-related fields of DataWrapperBase could cause problems if these fields are to be serialized.

Kind regards,
Daniel Rose
Comments:

Explained

Closed Issue: DoubleClickData is internal and cannot be used [4347]

sachabarber — Sun, 27 Nov 2011 18:13:41 GMT

Hello Sacha,

Unless I am mistaken, the class DoubleClickData is internal and cannot be used as a parameter with the SelectorDoubleClickCommandBehavior. I think it should be made public.

Damien
Comments:

Done

Closed Issue: NET Framework 4 [4362]

sachabarber — Sun, 27 Nov 2011 18:13:30 GMT

Hi.
There is a problem with the new NET Framework release.
Command Mappings throws an exception.
Get property 'Cinch.EventCommander.Mappings' threw an exception.
Inner Exception : {"Cannot get write-only property 'Cinch.EventCommander.Mappings'."}
Comments:

Old v1 issue

Closed Issue: Setting Active Workspace View - a better way? [4528]

sachabarber — Sun, 27 Nov 2011 18:13:13 GMT

Hi Sacha,

I have implemented in my code, a different way, when setting the active workspace to an already existing view, that I thought I'd share, and removes the requirement for a message to be displayed.
I thought the app should be able to take you to the view that you select even if its open.

By replacing in MainWindowViewModel ExecuteSearchCusomersCommand (spelling...!?!)
if (!IsNewWorkSpaceItemAllowed<SearchCustomersViewModel>())
{
this.SetActiveWorkspace(this.RetrievePreviousWorkSpaceItem<SearchCustomersViewModel>());
return;
}

And add:
/// <summary>
/// Changes focus to the selected workspace item
/// </summary>
/// <typeparam name="T">The type to check for</typeparam>
/// <returns>Returns the workspace item</returns>
private ViewModelBase RetrievePreviousWorkSpaceItem<T>()
{
foreach (var item in Workspaces)
{
if (item.GetType().Equals(typeof(T)))
{
return item;
}
}
return null;
}

What do you think??
Comments:

Not an issue